YoursFunny/TelegramTwitterMediaBot
1
0
Fork 0
mirror of https://github.com/TheFunny/TelegramTwitterMediaBot.git synced 2026-09-25 23:52:04 +00:00
Code Releases Activity

test(x-media): gate the pixiv download test as live-network too

Browse Source 
The pixiv download test was token-gated but not #[ignore]d, so a shell with PIXIV_REFRESH_TOKEN exported made every local cargo test --workspace hit i.pximg.net — where it demonstrably flaked (twice in one session: TLS EOF mid-body) — and CI's non-ignored step ran it as a side effect of having a secret. It carries the convention's #[ignore = "live network: …"] now and is renamed with the live_ prefix so the live job's --ignored live name filter actually picks it up (the old name did not contain 'live' and would have been filtered out). Its skip prints the SKIP prefix the next commit's live job greps, and AGENTS.md stops claiming a local workspace run is not fully offline.
This commit is contained in:
YoursFunny
2026-09-24 03:44:06 +08:00
parent e99f8b0bc0
commit a49bb1d1af
2 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/x-media/src/site/download.rs
+11 -5
View File
@@ -406,17 +406,23 @@ mod tests {
}
#[tokio::test]
async fn download_media_pixiv_original_with_referer() {
#[ignore = "live network: requires PIXIV_REFRESH_TOKEN and i.pximg.net"]
async fn live_download_media_pixiv_original_with_referer() {
// Proves the Referer header is attached for i.pximg.net: a header-less
// GET to a pixiv original URL is rejected with 403.
// Empty-string check too: an unset CI secret arrives as "" (GitHub
// Actions), which would otherwise run the test tokenless and fail.
// GET to a pixiv original URL is rejected with 403. `#[ignore]` as
// well as the token gate: this hit the CDN on every `cargo test
// --workspace` in a token-exported shell (and flaked on a CDN body
// timeout there), and the `live_` name puts it inside the CI live
// job's `--ignored live` filter. Empty-string check too: an unset CI
// secret arrives as "" (GitHub Actions), which would otherwise run
// the test tokenless and fail — the `SKIP` prefix is what the live
// job greps to tell a skip from a pass.
if std::env::var("PIXIV_REFRESH_TOKEN")
.ok()
.filter(|s| !s.is_empty())
.is_none()
{
eprintln!("skipping: no PIXIV_REFRESH_TOKEN");
eprintln!("SKIP (no PIXIV_REFRESH_TOKEN): not running the pixiv download test");
return;
}
let illustration = pixiv::fetch(126839080).await.unwrap();