refactor(x-media): hoist the shared caption builder

bilibili and misskey each had a byte-identical caption() (same escaping,
same empty-text early return, differing only in a named format argument).
site::caption holds it once; both adapters call it.
This commit is contained in:
2026-09-21 17:29:18 +08:00
parent dd98a90a45
commit 5222cfa1cb
3 changed files with 22 additions and 30 deletions
+2 -15
View File
@@ -30,7 +30,7 @@
use super::model;
use crate::media::Media;
use crate::site::{FetchError, Fetched, RenderData, Site, SiteFuture, compose_text};
use html_escape::{encode_double_quoted_attribute, encode_text};
use html_escape::encode_text;
use regex::Regex;
use std::sync::LazyLock;
use std::sync::atomic::{AtomicBool, Ordering};
@@ -276,7 +276,7 @@ impl From<model::Item> for Fetched {
let text = compose_text(&title, &content);
let tags = topic_name(&item).to_string();
let caption = caption(&url, &author_url, &author, &text);
let caption = crate::site::caption(&url, &author_url, &author, &text);
let media = media_of(&item);
Fetched {
@@ -485,19 +485,6 @@ fn to_https(url: &str) -> String {
}
}
fn caption(url: &str, author_url: &str, author: &str, text: &str) -> String {
let url = encode_double_quoted_attribute(url);
let author_url = encode_double_quoted_attribute(author_url);
let author = encode_text(author);
if text.is_empty() {
return format!("{url}\n<a href=\"{author_url}\">{author}</a>");
}
format!(
"{url}\n<a href=\"{author_url}\">{author}</a>: {}",
encode_text(text)
)
}
#[cfg(test)]
mod tests {
use super::*;